Unified push nextcloud notifications #47763
Conversation
…elated changes in nextcloud app
…cations. Signed-off-by: Gavin Element <[email protected]>
gavine99
force-pushed
the
unified_push_nextcloud_notifications
branch
from
76e0f4d
to
434966e
Compare
…elated changes in nextcloud app. linted. Signed-off-by: Gavin Element <[email protected]>
| * @since 9.0.0 | ||
| * @since 30.0.0 throws {@see IncompleteNotificationException} instead of \InvalidArgumentException |
There was a problem hiding this comment.
| * @since 9.0.0 | |
| * @since 30.0.0 throws {@see IncompleteNotificationException} instead of \InvalidArgumentException | |
| * @since 31.0.0 |
| } catch (\InvalidArgumentException $e) { | ||
| // todo 33.0.0 Log as warning | ||
| // todo 39.0.0 Log as error | ||
| $this->logger->debug(get_class($app) . '::notify() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\IncompleteNotificationException when the notification is incomplete for your app and otherwise handle all \InvalidArgumentException yourself.'); |
There was a problem hiding this comment.
| } catch (\InvalidArgumentException $e) { | |
| // todo 33.0.0 Log as warning | |
| // todo 39.0.0 Log as error | |
| $this->logger->debug(get_class($app) . '::notify() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\IncompleteNotificationException when the notification is incomplete for your app and otherwise handle all \InvalidArgumentException yourself.'); |
But I'm also not sure about the other catch.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
minimal changes to set the stage to allow the existing 3rd party nextcloud unified push app to send system notifications as push notifications to nextcloud mobile client and talk apps - https://apps.nextcloud.com/apps/uppush / https://codeberg.org/NextPush/uppush.
requires deployment sync with pull request for nextcloud notifications app with same title - nextcloud/notifications#2027
these pull requests are independent of, but will ultimately work with, a pull request for the unified push app to enable it to send push notifications to the nextcloud mobile client and talk apps - https://codeberg.org/NextPush/uppush/pulls/17
i have also submitted pr's for the generic (f-droid) android nextcloud client and talk apps to leverage the pr's above to create an end-to-end solution for unified push notifications and talk;
nextcloud mobile client app: nextcloud/android#13516
nextcloud mobile talk app: nextcloud/talk-android#4169